Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#57367] Disable edit for OneDrive/Sharepoint with AMPF enabled #16497

Conversation

akabiru
Copy link
Member

@akabiru akabiru commented Aug 21, 2024

https://community.openproject.org/work_packages/57367

OneDrive/SharePoint storages that have AMPF activated do not have this option as the user can not change any settings. and the button should not be shown in that case.

@akabiru akabiru marked this pull request as ready for review August 21, 2024 12:19
@akabiru
Copy link
Member Author

akabiru commented Aug 21, 2024

more flaky tests

@akabiru akabiru self-assigned this Aug 25, 2024
Copy link
Member

@Kharonus Kharonus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akabiru akabiru merged commit 6d96d8a into dev Aug 26, 2024
9 checks passed
@akabiru akabiru deleted the implementation/57367-disable-edit-for-onedrivesharepoint-with-ampf-enabled branch August 26, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants