Implementation/57028 removal of a project leaves some angular components as not clickable #16495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f3a0db2. Update the controller to respond with partial turbo streams instead of a full page redirect with turbo enabled. This caused DOM load issues with angular components, as Turbo would not break out of it's navigation frame- to remount the angular web components. The solution here is also used in other similar pages such as project attributes.
akabiru
commented
Aug 21, 2024
| disabled: true, | ||
| data: { | ||
| "disable-when-checked-target": "effect", | ||
| "close-dialog-id": id |
There was a problem hiding this comment.
@judithroth One odd thing is I had to specify the close-dialog-id - in other cases, the dialog closes automatically on submit 🤷🏾
| layout.with_row(mb: 3) do | ||
| render(Primer::Beta::Heading.new(tag: :h1, text_align: :center)) do | ||
| render(Primer::Beta::Octicon.new(icon: :alert, color: :danger, size: :medium)) | ||
| component_wrapper do |
There was a problem hiding this comment.
This is just for semantics and convention, but since async dialogs replace stream content via JS, it's technically not necessary- which is why it worked before without it.
judithroth
approved these changes
Aug 21, 2024
akabiru
deleted the
implementation/57028-removal-of-a-project-leaves-some-angular-components-as-not-clickable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.openproject.org/work_packages/57028
This reverts commit f3a0db2.
Update the controller to respond with partial turbo streams instead of a full page redirect with turbo enabled. This caused DOM load issues with angular components, as Turbo would not break out of it's navigation frame- to remount the angular web components. The solution here is also used in other similar pages such as project attributes.
Kapture.2024-08-21.at.14.10.11.mp4