[#57028] Fix Removal of a project leaves some js components unusable #16493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
judithroth
changed the title
akabiru
deleted the
implementation/57028-removal-of-a-project-leaves-some-angular-components-as-not-clickable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/work_packages/57028
What are you trying to accomplish?
Since this is a redirect and turbo would only replace the DOM contents, some JS events would not work after the contents were replaced. They rely on event handlers being registered and currently this only happens on full DOM load.
So we don't use turbo for this request any more to avoid this situation. There's already another work package to fix the behaviour of these elements, but that would be more work, so to be sure for now we're just using the "fast" solution here.
Merge checklist