Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[57341] Full height split screen #16483

Merged
merged 2 commits into from
Aug 21, 2024
Merged

[57341] Full height split screen #16483

merged 2 commits into from
Aug 21, 2024

Conversation

HDinger
Copy link
Contributor

@HDinger HDinger commented Aug 20, 2024 •
edited
Loading

Ticket

https://community.openproject.org/projects/openproject/work_packages/57341/activity
https://community.openproject.org/projects/openproject/work_packages/56890/activity

What are you trying to accomplish?

  • Let the new split screen in the notification center span the whole height of the the content
  • Mobile
    • Clicking a notification item technically opens the split screen (like in desktop), to be seen in the URL
    • The split screen spans the whole width and height of the screen (except for the app header which remains visible)
    • Closing the split screen via the "x" gets you back to the same view you saw before
    • The breakpoint to change the layout is lg

Screenshots

Bildschirmfoto 2024-08-20 um 12 20 44

Mobile

Bildschirmfoto 2024-08-21 um 10 30 43 Bildschirmfoto 2024-08-21 um 10 30 37

Merge checklist

  • Tested major browsers (Chrome, Firefox, Edge, ...)

@HDinger HDinger added this to the 14.5.x milestone Aug 20, 2024
@HDinger HDinger force-pushed the feature/57341-full-height-split-screen branch from 4d2936c to efc97de Compare August 21, 2024 06:41
@HDinger HDinger requested a review from a team August 21, 2024 08:36
@HDinger HDinger mentioned this pull request Aug 21, 2024
Closed
3 tasks
@HDinger HDinger force-pushed the feature/57341-full-height-split-screen branch from 9ee4193 to 0db9ffd Compare August 21, 2024 12:27
@oliverguenther oliverguenther requested review from oliverguenther and removed request for a team August 21, 2024 12:47
@oliverguenther oliverguenther merged commit 3089643 into dev Aug 21, 2024
9 checks passed
@oliverguenther oliverguenther deleted the feature/57341-full-height-split-screen branch August 21, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverguenther oliverguenther oliverguenther approved these changes

Assignees
No one assigned
Labels
feature
Milestone
14.5.x
Development

Successfully merging this pull request may close these issues.
2 participants
@HDinger @oliverguenther