Implementation/56922 trigger a login dialog when the user has no oauth access grant #16429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akabiru
force-pushed
the
implementation/56922-trigger-a-login-dialog-when-the-user-has-no-oauth-access-grant
branch
from
c1b0217
to
4f79263
Compare
akabiru
force-pushed
the
implementation/56922-trigger-a-login-dialog-when-the-user-has-no-oauth-access-grant
branch
from
4f79263
to
a617264
Compare
akabiru
force-pushed
the
implementation/56922-trigger-a-login-dialog-when-the-user-has-no-oauth-access-grant
branch
2 times, most recently
from
3977dd1
to
4d9bf5b
Compare
akabiru
force-pushed
the
implementation/56922-trigger-a-login-dialog-when-the-user-has-no-oauth-access-grant
branch
from
4d9bf5b
to
717d0c1
Compare
This reverts commit 5e8fff1.
judithroth
reviewed
Aug 19, 2024
...torages/app/components/storages/admin/storages/oauth_access_granted_modal_component.html.erb
Show resolved
Hide resolved
judithroth
approved these changes
Aug 20, 2024
akabiru
deleted the
implementation/56922-trigger-a-login-dialog-when-the-user-has-no-oauth-access-grant
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Prompt user to login to the storage provider so that manual folder selection is possible and background jobs that set up permissions and such can find a ready state once a storage is activated for n projects.
Screenshots
Kapture.2024-08-19.at.11.41.13.mp4
porject-storages-oauth-nudge.mp4
What approach did you choose and why?
Reuse the existing OAuth Access Grant Nudge flow for single projects (#14792) splitting the grant success component and updating the design so that these are reusable in both scenarios.
Ticket
https://community.openproject.org/work_packages/56922
Merge checklist