Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User interface for SAML configuration #16377

Merged
merged 80 commits into from
Sep 26, 2024
Merged

User interface for SAML configuration #16377

merged 80 commits into from
Sep 26, 2024

Conversation

oliverguenther
Copy link
Member

@oliverguenther oliverguenther commented Aug 8, 2024 •
edited
Loading

Ticket

https://community.openproject.org/work_packages/40279

TODOS

  • Migrate existing ENV based configuration to providers with seeded ENV like LDAP
    • Seeded by env are read-only while ENV keys remain
  • Convert existing settings-based configuration to using migration
  • Providers specs
    • Contracts
    • Services
    • Feature spec
    • Metadata endpoint spec
    • Auth callback spec

@oliverguenther oliverguenther marked this pull request as draft August 8, 2024 19:21
@oliverguenther oliverguenther force-pushed the feature/saml-ui branch 2 times, most recently from 97dccd2 to 5a50910 Compare August 21, 2024 12:56
@oliverguenther oliverguenther added this to the 15.x milestone Aug 22, 2024
@oliverguenther oliverguenther force-pushed the feature/saml-ui branch 3 times, most recently from 378a94e to 29e36bf Compare August 23, 2024 08:57
@oliverguenther oliverguenther force-pushed the feature/saml-ui branch 5 times, most recently from d38db5d to 931da9d Compare August 28, 2024 06:32
machisuji
machisuji requested changes Sep 3, 2024
View reviewed changes
Copy link
Member

@machisuji machisuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic! Thanks for the great work. Seems to be working quite well. Although I have probably missed a couple of things.

I only have a few minor remarks. Could you please have a look?

modules/auth_saml/app/contracts/saml/providers/base_contract.rb Show resolved Hide resolved
modules/auth_saml/app/components/saml/providers/row_component.rb Outdated Show resolved Hide resolved
modules/auth_saml/app/services/saml/providers/set_attributes_service.rb Show resolved Hide resolved
modules/auth_saml/config/locales/en.yml Show resolved Hide resolved
modules/auth_saml/config/locales/en.yml Outdated Show resolved Hide resolved
modules/auth_saml/config/locales/en.yml Outdated Show resolved Hide resolved
modules/auth_saml/config/locales/en.yml Show resolved Hide resolved
modules/storages/spec/requests/project_storages_open_spec.rb Outdated Show resolved Hide resolved
modules/storages/spec/requests/project_storages_open_spec.rb Outdated Show resolved Hide resolved
@oliverguenther oliverguenther force-pushed the feature/saml-ui branch 2 times, most recently from e4f07f2 to 8de17dc Compare September 5, 2024 07:59
@oliverguenther oliverguenther force-pushed the feature/saml-ui branch 2 times, most recently from 6ad4bc1 to 08df031 Compare September 9, 2024 18:34
@oliverguenther oliverguenther marked this pull request as ready for review September 26, 2024 09:36
machisuji
machisuji approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@machisuji machisuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@machisuji machisuji merged commit a73e90b into dev Sep 26, 2024
13 checks passed
@machisuji machisuji deleted the feature/saml-ui branch September 26, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machisuji machisuji machisuji approved these changes

Assignees
No one assigned
Labels
feature needs review
Milestone
15.x
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverguenther @machisuji @psatyal