Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug that did not allow removing permissions from a global role #13182

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

klaustopher
Copy link
Contributor

No description provided.


require 'spec_helper'

RSpec.describe 'Role updating', js: true, with_cuprite: true do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Contributor

@aaron-contreras aaron-contreras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a while to get that it was the memberPermissions being rendered as well and thus causing an override. Nice catch!

@aaron-contreras aaron-contreras merged commit c41d6d8 into dev Jul 19, 2023
11 checks passed
@aaron-contreras aaron-contreras deleted the fix-global-roles-form branch July 19, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants