more refactorings to resolve rubocop issues

opf · Aug 20, 2024 · 75a358f · 75a358f
1 parent 87ec0da
commit 75a358f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/app/components/work_packages/activities_tab/journals/item_component/details.rb b/app/components/work_packages/activities_tab/journals/item_component/details.rb
@@ -97,7 +97,11 @@ def render_user_name_and_time(container)
 
         def render_created_or_changed_on_text(container)
           container.with_column(mr: 1, classes: "hidden-for-mobile") do
-            text_key = journal.initial? ? "activities.work_packages.activity_tab.created_on" : "activities.work_packages.activity_tab.changed_on"
+            text_key = if journal.initial?
+                         "activities.work_packages.activity_tab.created_on"
+                       else
+                         "activities.work_packages.activity_tab.changed_on"
+                       end
             render(Primer::Beta::Text.new(font_size: :small, color: :subtle, mt: 1)) { t(text_key) }
           end
         end

diff --git a/app/controllers/work_packages/activities_tab_controller.rb b/app/controllers/work_packages/activities_tab_controller.rb
@@ -170,7 +170,7 @@ def journal_params
 
   def create_notification_service_call
     ### taken from ActivitiesByWorkPackageAPI
-    call = AddWorkPackageNoteService
+    AddWorkPackageNoteService
       .new(user: User.current,
            work_package: @work_package)
       .call(journal_params[:notes],