fix[Op#40437]: ensure all wp journals are updated including removals

opf · Oct 25, 2024 · 0d7d897 · 0d7d897
1 parent 80cea6e
commit 0d7d897
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/app/controllers/work_packages/activities_tab_controller.rb b/app/controllers/work_packages/activities_tab_controller.rb
@@ -330,12 +330,12 @@ def generate_time_based_update_streams(last_update_timestamp)
   end
 
   def generate_work_package_journals_emoji_reactions_update_streams
-    # Current limitation: Only shows added reactions, not removed ones
-    Journal.grouped_work_package_journals_emoji_reactions(@work_package).each do |journal_id, grouped_emoji_reactions|
+    wp_journal_emoji_reactions = Journal.grouped_work_package_journals_emoji_reactions(@work_package)
+    @work_package.journals.each do |journal|
       update_via_turbo_stream(
         component: WorkPackages::ActivitiesTab::Journals::ItemComponent::Reactions.new(
-          journal: @work_package.journals.find(journal_id),
-          grouped_emoji_reactions:
+          journal:,
+          grouped_emoji_reactions: wp_journal_emoji_reactions[journal.id] || {}
         )
       )
     end