Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to latest LTS Java 21 and recent maven #76

Merged
merged 2 commits into from
Dec 2, 2023

Conversation

codefromthecrypt
Copy link
Member

@codefromthecrypt codefromthecrypt commented Dec 2, 2023

This updates to the latest LTS version of Java 21.

This also updates maven as it has drifted a while, and removes a jlink workaround that seems no longer necessary.

from my mac silicon after running build per README

$ docker run --rm openzipkin/java:test -version
openjdk version "21.0.1" 2023-10-17
OpenJDK Runtime Environment (build 21.0.1+12-alpine-r0)
OpenJDK 64-Bit Server VM (build 21.0.1+12-alpine-r0, mixed mode, sharing)
$ docker run --rm --entrypoint /bin/sh openzipkin/java:test -c 'mvn -version'
Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
Maven home: /java/maven
Java version: 21.0.1, vendor: Alpine, runtime: /usr/lib/jvm/java-21-openjdk
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "6.5.0-10-generic", arch: "aarch64", family: "unix"

cc @NishikantThorat we can try your ppc64le after this, though there may be other problems in the downstream images (zipkin uses the base to test elasticsearch etc, and also we may be moving off alpine anyway). In other words, I'm not sure if folks besides you will be able to support it.

Marking draft until openzipkin/docker-alpine#35

This updates to the latest LTS version of Java 21.

This also updates maven as it has drifted a while, and removes a jlink
workaround that seems no longer necessary.

Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt
Copy link
Member Author

openzipkin/zipkin#3606 matches this version of maven

Signed-off-by: Adrian Cole <[email protected]>
@codefromthecrypt codefromthecrypt marked this pull request as ready for review December 2, 2023 02:53
@codefromthecrypt codefromthecrypt merged commit 4ae30ff into master Dec 2, 2023
1 check passed
@codefromthecrypt codefromthecrypt deleted the openjdk-21 branch December 2, 2023 03:03
@codefromthecrypt
Copy link
Member Author

thanks for the look @anuraaga!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants