fix(sec): upgrade io.netty:netty-codec-http to 4.1.86.final #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
requested changes
Feb 21, 2023
pom.xml
Outdated
| @@ -114,7 +114,7 @@ | |||
| <grpc.version>1.34.1</grpc.version> | |||
| <protobuf.version>3.12.0</protobuf.version> | |||
| <!-- prefer grpc's version of netty --> | |||
| <netty.version>4.1.71.Final</netty.version> | |||
| <netty.version>4.1.86.final</netty.version> | |||
There was a problem hiding this comment.
The comment above this leads me to believe we might run into issues if we do not also upgrade the version of grpc.
|
Any movement here? |
|
I corrected the alignment rather than nag |
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
force-pushed
the
oscs_fix_cfbn36gau51u2n4fth60
branch
from
6da6cf2 to
351750e
Compare
codefromthecrypt
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened？
There are 1 security vulnerabilities found in io.netty:netty-codec-http 4.1.71.Final
What did I do？
Upgrade io.netty:netty-codec-http from 4.1.71.Final to 4.1.86.final for vulnerability fix
What did you expect to happen？
Ideally, no insecure libs should be used.
The specification of the pull request
PR Specification from OSCS