Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zimfarm endpoint now contains flags as subkey in dictionary #52

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Zimfarm endpoint now contains flags as subkey in dictionary #52

merged 1 commit into from
Apr 8, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Apr 8, 2024 •
edited
Loading

Currently the "advanced options" do not display anymore

Changes:

@benoit74 benoit74 self-assigned this Apr 8, 2024
@benoit74 benoit74 requested a review from rgaudin April 8, 2024 06:41
@benoit74 benoit74 marked this pull request as ready for review April 8, 2024 06:41
@benoit74
Copy link
Collaborator Author

benoit74 commented Apr 8, 2024

(quite urgent since UI is currently broken, but it has been so for days so it can wait few hours for a review)

rgaudin
rgaudin approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74 benoit74 merged commit 2de33a5 into main Apr 8, 2024
2 checks passed
@benoit74 benoit74 deleted the fix_offliner_flags branch April 8, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees

@benoit74 benoit74

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benoit74 @rgaudin