Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't clear options - fixed #49

Merged
merged 1 commit into from
Feb 29, 2024
Merged

can't clear options - fixed #49

merged 1 commit into from
Feb 29, 2024

Conversation

krutarthjankat
Copy link
Contributor

@krutarthjankat krutarthjankat commented Feb 27, 2024

Fix #35

Hi, I am Krutarth Jankat, I have tried to fix the clear options issue by just filtering out empty strings at the time of submission. Please check if this is what was required

@benoit74 benoit74 self-requested a review February 29, 2024 10:15
Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Some remark for next PR:

  • you have to add Fix #xxx in your first comment (I did it for you) to link the PR with the corresponding issue (where xxx is the issue number, see https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
  • you must not commit your changes to a main branch but to a newly created branch (this will be especially important one we will give you developper permissions on this repo) ; the newly created branch should be name according to the intent of the changes, e.g. clear_flags

Please read https://github.com/openzim/overview/wiki/openZIM-code-contribution-workflow with a lot of attention to all details.

@benoit74
Copy link
Collaborator

And it would help if your PR title explains what the PR does, e.g. "Options / payload flags clearing", not what the original problem was.

@benoit74 benoit74 merged commit f054dbe into openzim:main Feb 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't clear options
2 participants