Display more useful errors in the UI #44
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
ZIMIT_KUBE_CONFIG
secret must be set in repo before mergingChanges
error
orerror_description
ormessage
fields ; in fact this response comes from Zimit API and we know there is only a potentialerror
fielderror
field is present in the API response, display it "as-is" and without Zimit API HTTP response code (this is too technical for the end user + we return almost always the same one) ; display it no matter the HTTP response code (it was only done for HTTP 400 before)NOTA:
Screenshots
Before:
After, when API provides error data:
After, when API does not provide error data but just HTTP status code (and maybe other data we do not know how to use):