Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make URL secrets removal more resilient #1019

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Make URL secrets removal more resilient #1019

merged 1 commit into from
Sep 20, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Sep 19, 2024

Fix #1012

When we do not achieve to parse the URL, then we are probably not dealing with a URL so we can keep it as-is and avoid to crash.

We should probably check once per month if there is something sensible which has been ignored by this code thanks to logs in grafana.

@benoit74 benoit74 self-assigned this Sep 19, 2024
@benoit74 benoit74 marked this pull request as ready for review September 19, 2024 13:01
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.29%. Comparing base (27fac52) to head (3b3f87c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
dispatcher/backend/src/routes/utils.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1019      +/-   ##
==========================================
- Coverage   88.33%   88.29%   -0.05%     
==========================================
  Files          96       96              
  Lines        5385     5389       +4     
==========================================
+ Hits         4757     4758       +1     
- Misses        628      631       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We saw it coming though

@benoit74 benoit74 merged commit 72481c2 into main Sep 20, 2024
5 of 7 checks passed
@benoit74 benoit74 deleted the remove_secrets branch September 20, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP 500 error in backend API in remove_secrets
2 participants