Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework/fixes for zimit-frontend #1014

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Rework/fixes for zimit-frontend #1014

merged 2 commits into from
Sep 12, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Sep 12, 2024

Remark:

  • ?hide_secrets= tested locally, works well, complex to test in automated end-to-end

@benoit74 benoit74 self-assigned this Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.33%. Comparing base (100313b) to head (60cc6cb).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1014      +/-   ##
==========================================
+ Coverage   88.28%   88.33%   +0.05%     
==========================================
  Files          96       96              
  Lines        5360     5385      +25     
==========================================
+ Hits         4732     4757      +25     
  Misses        628      628              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review September 12, 2024 09:57
@benoit74
Copy link
Collaborator Author

Edit: update first message with some details

@benoit74 benoit74 changed the title More work on secrets hidding Rework/fixes for zimit-frontend Sep 12, 2024
@benoit74
Copy link
Collaborator Author

Edit: added notification property on requested-tasks endpoint, it is needed / used by zimit-frontend

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ; indeed a new use case: authenticated but without secrets.

@benoit74 benoit74 merged commit f0dbbe1 into main Sep 12, 2024
7 checks passed
@benoit74 benoit74 deleted the hide_secrets_on_demand branch September 12, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add query parameter to hide schedule / task secret flags on-demand
2 participants