Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stats-filename in youtube, and mark it as progress capable for worker #1011

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Sep 5, 2024

Rationale

Youtube 3.1.0 now supports a --stats-filename setting to report task progress

@benoit74 benoit74 self-assigned this Sep 5, 2024
@benoit74 benoit74 marked this pull request as ready for review September 5, 2024 12:06
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.28%. Comparing base (23bf769) to head (4f74b3d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1011   +/-   ##
=======================================
  Coverage   88.28%   88.28%           
=======================================
  Files          96       96           
  Lines        5359     5360    +1     
=======================================
+ Hits         4731     4732    +1     
  Misses        628      628           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74 benoit74 merged commit 100313b into main Sep 10, 2024
7 checks passed
@benoit74 benoit74 deleted the youtube_3_1_0 branch September 10, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants