Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect conflict of ZIM names across recipes #1037

Open
benoit74 opened this issue Oct 27, 2024 · 1 comment
Open

Detect conflict of ZIM names across recipes #1037

benoit74 opened this issue Oct 27, 2024 · 1 comment

Comments

@benoit74
Copy link
Collaborator

ZIM names must be unique to a single recipe, no matter the warehouse path / offliner in use, to avoid conflicting / overriding recipes and hard to debug situations.

Even when ZIMs are published to distinct warehouse path, I don't think that have conflicting names can bring anything good.

We need to be able to detect that issue at recipe configuration time and prevent such configuration from being saved, based on currently configured recipes. I.e. fail with something like "you cannot use this ZIM name which is already used by this recipe".

The corollary is probably that we must change / remove the ZIM name at recipe clone time, because this is the typical situation where we create a conflict, and should the editor forget to modify this setting, then we have conflict / overriding recipes.

This will not save us from a recipe overriding a ZIM which has been manually uploaded or created by a deleted recipe, but this last case is probably very rare and very hard to diagnose by the machine (and we might want to do it intentionally).

@rgaudin
Copy link
Member

rgaudin commented Oct 28, 2024

ZIM Name is the readable identifier of the ZIM (along with Publisher and Flavour). It is already agreed that those should be unique.

Indeed simply removing ZIM name when cloning will be a huge win for a minimal effort (exact field setting name must be identified for all offliners though) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants