Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect duplicate schedule names when cloning a schedule #844

Open
benoit74 opened this issue Oct 12, 2023 · 7 comments · May be fixed by #862
Open

Detect duplicate schedule names when cloning a schedule #844

benoit74 opened this issue Oct 12, 2023 · 7 comments · May be fixed by #862

Comments

@benoit74
Copy link
Collaborator

  • Location: API / UI

Problem

When cloning a schedule, if the new chosen name is already in used, this is only detected at the DB level, raising a 500 error.

We should detect this at least at the API level, and maybe also at the UI level (effort to be investigated).

Reproducing steps

Clone a schedule and choose a name which is already in use.

@kelson42
Copy link
Contributor

kelson42 commented Nov 1, 2023

Duplicate of #740

@kelson42 kelson42 marked this as a duplicate of #740 Nov 1, 2023
@kelson42 kelson42 closed this as completed Nov 1, 2023
@benoit74
Copy link
Collaborator Author

benoit74 commented Nov 1, 2023

This is not really a duplicate, I was only speaking about duplicated names. Not about duplicated configuration as in #740. This issue is probably way easier to solve than #740 and would avoid 500 errors

@kelson42 kelson42 reopened this Nov 1, 2023
@kelson42 kelson42 removed the duplicate label Nov 1, 2023
rgaudin added a commit that referenced this issue Nov 2, 2023
Same behavior as for schedule creation (that API supports but UI does not)
@rgaudin rgaudin linked a pull request Nov 2, 2023 that will close this issue
@kelson42
Copy link
Contributor

kelson42 commented Oct 19, 2024

@benoit74 Today, I lost around 15 mn because of that issue. Considering we have a PR we should anyway be treated/improved/... and the impact is very "vicious" (old ZIM disappear from library.kiwix.org) Could you please fix this in priority?

@benoit74
Copy link
Collaborator Author

@kelson42 I don't think your problem is the same as this issue. This issue (and corresponding PR) is speaking about duplicated schedule name. You seem to have an issue about duplicate ZIM name. This is a distinct problem far more complex to solve (please open an issue if you confirm your problem is a different problem). As indicated here, this issue is only about better handling of duplicate schedule name which are currently raising 500 errors. And this is seemed not a very important thing since it is very rare to happen in our history (we are being alarmed on every 500 error since months now).

@benoit74
Copy link
Collaborator Author

@kelson42 I'm still waiting on your feedback about your recent issue. Can you clarify what made you loose 15 mn of your precious time so that we know what needs to be enhanced to not do it again? I'm quite sure your problem is duplicate ZIM name and not duplicate recipe name, but I would like to have your confirmation.

@kelson42
Copy link
Contributor

@benoit74 You are 100% right, this is a duplicate ZIM metadata "Name". My bad.

@benoit74
Copy link
Collaborator Author

I isolated your specific issue here: #1037

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants