-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect duplicate schedule names when cloning a schedule #844
Comments
Duplicate of #740 |
Same behavior as for schedule creation (that API supports but UI does not)
@benoit74 Today, I lost around 15 mn because of that issue. Considering we have a PR we should anyway be treated/improved/... and the impact is very "vicious" (old ZIM disappear from library.kiwix.org) Could you please fix this in priority? |
@kelson42 I don't think your problem is the same as this issue. This issue (and corresponding PR) is speaking about duplicated schedule name. You seem to have an issue about duplicate ZIM name. This is a distinct problem far more complex to solve (please open an issue if you confirm your problem is a different problem). As indicated here, this issue is only about better handling of duplicate schedule name which are currently raising 500 errors. And this is seemed not a very important thing since it is very rare to happen in our history (we are being alarmed on every 500 error since months now). |
@kelson42 I'm still waiting on your feedback about your recent issue. Can you clarify what made you loose 15 mn of your precious time so that we know what needs to be enhanced to not do it again? I'm quite sure your problem is duplicate ZIM name and not duplicate recipe name, but I would like to have your confirmation. |
@benoit74 You are 100% right, this is a duplicate ZIM metadata "Name". My bad. |
I isolated your specific issue here: #1037 |
Problem
When cloning a schedule, if the new chosen name is already in used, this is only detected at the DB level, raising a 500 error.
We should detect this at least at the API level, and maybe also at the UI level (effort to be investigated).
Reproducing steps
Clone a schedule and choose a name which is already in use.
The text was updated successfully, but these errors were encountered: