Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache subtitles in S3 storage #287

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+55 −5

Update `download_subtitles` method to cache subtitles in S3 storage

d34a734
Select commit
Loading
Failed to load commit list.
Draft

Cache subtitles in S3 storage #287

Update `download_subtitles` method to cache subtitles in S3 storage
d34a734
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 4, 2024 in 0s

1.50% (-0.05%) compared to 60b85b5

View this Pull Request on Codecov

1.50% (-0.05%) compared to 60b85b5

Details

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Project coverage is 1.50%. Comparing base (60b85b5) to head (d34a734).

Files Patch % Lines
scraper/src/youtube2zim/scraper.py 0.00% 34 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##            main    #287      +/-   ##
========================================
- Coverage   1.54%   1.50%   -0.05%     
========================================
  Files         11      11              
  Lines       1102    1132      +30     
  Branches     162     170       +8     
========================================
  Hits          17      17              
- Misses      1085    1115      +30

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov