MAP_POPULATE is Linux-specific and not declared on other platforms #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leleliu008 is this the only required change to support NetBSD? I'm not sure it makes sense to merge this if not. |
|
I also file a PR #928 These two PRs to support NetBSD. |
|
Great then |
|
After apply these two patches, I successfully built this project on NetBSD. I myself port this project for NetBSD https://github.com/leleliu008/ppkg-formula-repository-official-core/blob/master/formula/libzim.yml#L12C41-L13 |
mgautierfr
reviewed
Aug 30, 2024
leleliu008
force-pushed
the
fix-undeclared-MAP_POPULATE
branch
from
a4ceda9
to
47877d7
Compare
veloman-yunkan
approved these changes
Aug 30, 2024
leleliu008
changed the title
kelson42
force-pushed
the
fix-undeclared-MAP_POPULATE
branch
from
47877d7
to
51bdcf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.man7.org/linux/man-pages/man2/mmap.2.html
https://man.netbsd.org/mmap.2