[WIP] Introduce fuzzyRules storage and exploitation. #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allow user to add a new entry which is a `Clone` of a previously added one. The new entry is the "same" that the original one but for the path and title.
This is use in zim-check to not count clone entries as duplicated entries.
mgautierfr
force-pushed
the
fuzzy_rules
branch
from
0a1ebc1
to
5466abe
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## clone_entry #835 +/- ##
===============================================
- Coverage 57.60% 56.16% -1.45%
===============================================
Files 98 100 +2
Lines 4593 4786 +193
Branches 1924 2050 +126
===============================================
+ Hits 2646 2688 +42
- Misses 677 777 +100
- Partials 1270 1321 +51
☔ View full report in Codecov by Sentry. |
This commit does nothing with FuzzyRule but: - Introduce a serialization format for FuzzyRule - Test this serialization.
On aarch64, the compiler is a bit too old.
mgautierfr
force-pushed
the
fuzzy_rules
branch
from
7a70ac0
to
b01be3d
Compare
kelson42
force-pushed
the
clone_entry
branch
from
4d80e13
to
fa724ba
Compare
mgautierfr
force-pushed
the
clone_entry
branch
from
fa724ba
to
fcc3eec
Compare
mgautierfr
force-pushed
the
clone_entry
branch
from
fcc3eec
to
9a59af5
Compare
|
AFAIK we don’t need this code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #825
Fixes #826
FuzzyRule attribute follows the regex used by wabac service worker (see openzim/warc2zim#113)
While it follows what have been done in https://github.com/kiwix/libkiwix/tree/kiwix_no_sw POC.
However, the API and algorithm is not totally fixed and may involve when implementing and testing new warc2zim (without service worker).