Skip to content

Commit

Permalink
fixup! Do not inherit from std::iterator.
Browse files Browse the repository at this point in the history
  • Loading branch information
mgautierfr committed Sep 14, 2023
1 parent 62496cc commit 56f5850
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion include/zim/archive.h
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,7 @@ namespace zim
class LIBZIM_API Archive::iterator
{
public:
using iterator_category = std::bidirectional_iterator_tag;
using iterator_category = std::input_iterator_tag;
using value_type = Entry;
using pointer = Entry*;
using reference = Entry&;
Expand Down
2 changes: 1 addition & 1 deletion include/zim/search_iterator.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class LIBZIM_API SearchIterator
{
friend class zim::SearchResultSet;
public:
using iterator_category = std::bidirectional_iterator_tag;
using iterator_category = std::input_iterator_tag;
using value_type = Entry;
using pointer = Entry*;
using reference = Entry&;
Expand Down
4 changes: 2 additions & 2 deletions include/zim/suggestion_iterator.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ class LIBZIM_API SuggestionIterator
typedef Archive::iterator<EntryOrder::titleOrder> RangeIterator;
friend class SuggestionResultSet;
public:
using iterator_category = std::bidirectional_iterator_tag;
using iterator_category = std::input_iterator_tag;
using value_type = SuggestionItem;
using pointer = SuggestionItem*;
using referenc = SuggestionItem&;
using reference = SuggestionItem&;

SuggestionIterator() = delete;
SuggestionIterator(const SuggestionIterator& it);
Expand Down

0 comments on commit 56f5850

Please sign in to comment.