-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add breadcrumbs back + fix meaningfull URLs + add developpers instructions #74
Conversation
9c342f8
to
fe3ecc1
Compare
fe3ecc1
to
67df994
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you ;
Have you had the chance to run it on a large channel like Khan ?
Nope ... Is there a language which would make more sense? en/es/fr? |
I'd say FR because it's large and easier for you to spot issues when browsing |
I just started Khan Academy FR on my machine, it will probably run for many days so I propose to move forward this PR without waiting for the result, we are not yet at the point of merging this to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@rgaudin I assume it means I can resolve the conversation and merge the PR |
Would solve #66 and #64 and #31 once merged to
main
, but not yet ready to be merged in this branch (other issues have to be fixed)Changes: