Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #119

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Update README.md #119

merged 1 commit into from
Apr 9, 2024

Conversation

btrain01
Copy link
Contributor

Added command to activate the virtual environment when using Windows

@btrain01
Update README.md
3ed1611 
Added command to activate the virtual environment when using Windows
@btrain01
Copy link
Contributor Author

Hello, I'm fairly new to open-source and I'm looking to contribute to this project. I have specifically been looking at the new UI branch for Kolibri. This is my first pull request and I just made a small change to the README.md file. Do I need to tag someone to merge the pull request?

@Sudarshan-21
Copy link
Contributor

Hello, I'm fairly new to open-source and I'm looking to contribute to this project. I have specifically been looking at the new UI branch for Kolibri. This is my first pull request and I just made a small change to the README.md file. Do I need to tag someone to merge the pull request?

There is no rule about tagging someone or not, but the maintainers mostly will take care of reviewing all the things. But if you think they might have missed one, you might tag the maintainer.

@benoit74 benoit74 self-requested a review April 6, 2024 19:16
benoit74
benoit74 approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74 benoit74 merged commit 4835598 into openzim:main Apr 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoit74 benoit74 benoit74 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@btrain01 @Sudarshan-21 @benoit74