Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added loading animation #113

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

githyuvi
Copy link
Contributor

Solves issue #112
Before adding animation

beforeAnimation.mov

After adding animation

afterAnimation.mov
  • Used a new npm module "vue-loading-overlay" for animation

@benoit74 benoit74 self-requested a review March 18, 2024 12:23
Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@benoit74 benoit74 merged commit 3ce4cef into openzim:new_ui Mar 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants