Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-app-package-manager: Show the executed command #7376

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

hnyman
Copy link
Contributor

@hnyman hnyman commented Nov 3, 2024

Clarify the output of the LuCI package manager actions:
show also the exact command passed to apk & opkg
(in addition to output & errors from the command)
That will help debugging.

Examples:

installation:
image

removal:
image

image

@systemcrash
Copy link
Contributor

Good additions

@Ansuel
Copy link
Member

Ansuel commented Nov 3, 2024

Mhh maybe we can just change the call tool to append the command before the result?

@hnyman
Copy link
Contributor Author

hnyman commented Nov 3, 2024

You mean in style of
image

or
image

Clear enough. I will change that.

@Ansuel
Copy link
Member

Ansuel commented Nov 3, 2024

no i mean to modify the package-manager-call script instead of the .js to include the command in the res json. That way it's autoincluded as first line in the output.

But also the 2 box are ok and I like it. So make the 2 box implementation

@hnyman
Copy link
Contributor Author

hnyman commented Nov 3, 2024

I actually like it in the way above where the command is in its own box, slightly separated from the results.

@Ansuel
Copy link
Member

Ansuel commented Nov 3, 2024

I actually like it in the way above where the command is in its own box, slightly separated from the results.

yep ok for me

Clarify the output of the LuCI package manager actions:
show also the exact command passed to apk & opkg
(in addition to output & errors from the command)

Signed-off-by: Hannu Nyman <[email protected]>
@hnyman hnyman merged commit d90728d into openwrt:master Nov 3, 2024
3 of 4 checks passed
@hnyman hnyman deleted the pmdebug branch November 3, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants