Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-mod-dashboard: Fix the model name misalignment #7366

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Skym3
Copy link

@Skym3 Skym3 commented Oct 30, 2024

The model name misalignment, with "out" appearing on a separate line, is due to inline-block styling in luci-mod-dashboard, which causes unintended text wrapping. Switching to inline-flex fixes this by keeping elements on the same line.

381702541-79d00693-8360-4de1-a545-804780645643

  • This PR is not from my main or master branch 💩, but a separate branch ✅
  • Each commit has a valid ✒️ Signed-off-by: <[email protected]> row (via git commit --signoff)
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages
  • Incremented 🆙 any PKG_VERSION in the Makefile
  • Tested on: (architecture, openwrt version, browser) ✅
  • ( Preferred ) Mention: @ the original code author for feedback
  • ( Preferred ) Screenshot or mp4 of changes:
  • ( Optional ) Closes: e.g. openwrt/luci#issue-number
  • ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
  • Description: (describe the changes proposed in this PR)

The model name misalignment, with "out" appearing on a separate line, is due to `inline-block` styling in `luci-mod-dashboard`, which causes unintended text wrapping. Switching to `inline-flex` fixes this by keeping elements on the same line.

Signed-off-by: fkhan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant