luci-app-watchcat: Add support for ping timeout #7337
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Q: are the po files automatically generated or should I run some command in this PR generate them? |
3 tasks
|
If you've added a new feature, run in your luci repo e.g.: build/i18n-sync.sh applications/luci-app-watchcat/ |
Signed-off-by: Mathieu A <[email protected]>
Signed-off-by: Mathieu A <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not from my main or master branch 💩, but a separate branch ✅
Each commit has a valid ✒️
Signed-off-by: <[email protected]>row (viagit commit --signoff)Each commit and PR title has a valid 📝
<package name>: titlefirst line subject for packagesIncremented 🆙 any
PKG_VERSIONin the MakefileTested on: (ath79/generic, OpenWrt 23.05.4 r24012-d8dd03c46f, Firefox 131.0.3) ✅
( Preferred ) Mention: @systemcrash
( Preferred ) Screenshot or mp4 of changes:
( Optional ) Closes:
( Optional ) Depends on: e.g. watchcat: allow define custom timeout packages#25173 in sister repo
Description: (describe the changes proposed in this PR)
Add a new form field to permit set the ping timeout value