Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-app-watchcat: Typo in watchcat.js #7336

Merged
merged 2 commits into from
Oct 19, 2024
Merged

Conversation

kumy
Copy link
Contributor

@kumy kumy commented Oct 19, 2024

  • This PR is not from my main or master branch πŸ’©, but a separate branch βœ…
  • Each commit has a valid βœ’οΈ Signed-off-by: <[email protected]> row (via git commit --signoff)
  • Each commit and PR title has a valid πŸ“ <package name>: title first line subject for packages
  • Incremented πŸ†™ any PKG_VERSION in the Makefile
  • Tested on: (architecture, openwrt version, browser) βœ…
  • ( Preferred ) Mention: @ the original code author for feedback
  • ( Preferred ) Screenshot or mp4 of changes:
  • ( Optional ) Closes: e.g. openwrt/luci#issue-number
  • ( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
  • Description: (describe the changes proposed in this PR)

A small PR to fix a typo.

image

@systemcrash
Copy link
Contributor

Good that you spotted this. Now please update all of the other i18n strings so you don't orphan the i18n language strings.

@systemcrash
Copy link
Contributor

A simple search and replace for ModemManger should do it.

@kumy
Copy link
Contributor Author

kumy commented Oct 19, 2024

@systemcrash done βœ”οΈ

@systemcrash
Copy link
Contributor

I don't really understand that stray </i> in there. But that's a problem for another day, unless you want to prune it out.

@kumy
Copy link
Contributor Author

kumy commented Oct 19, 2024

That's more than what I was going to fix first :)

I've added 2 missing <i>, as it was present on line 104 and missing on 94 / 111 and updated all existing translations.

o = s.taboption('general', form.Value, 'forcedelay',
_('Force Reboot Delay'),
_("Applies to Ping Reboot and Periodic Reboot modes</i> <br /> When rebooting the router, the service will trigger a soft reboot. \
Entering a non-zero value here will trigger a delayed hard reboot if the soft reboot were to fail. \
Enter the number of seconds to wait for the soft reboot to fail or use 0 to disable the forced reboot delay."));
o.default = '1m';
o.depends({ mode: 'ping_reboot' });
o.depends({ mode: 'periodic_reboot' });
o = s.taboption('general', widgets.DeviceSelect, 'interface',
_('Interface'),
_('Interface to monitor and/or restart'),
_('<i>Applies to Ping Reboot, Restart Interface, and Run Script modes</i> <br /> Specify the interface to monitor and react if a ping over it fails.'));
o.depends({ mode: 'ping_reboot' });
o.depends({ mode: 'restart_iface' });
o.depends({ mode: 'run_script' });
o = s.taboption('general', widgets.NetworkSelect, 'mmifacename',
_('Name of ModemManager Interface'),
_("Applies to Ping Reboot and Restart Interface modes</i> <br /> If using ModemManager, \
you can have Watchcat restart your ModemManger interface by specifying its name."));

@systemcrash
Copy link
Contributor

You'll need to update your sign-off email for the checks to pass.

@kumy
Copy link
Contributor Author

kumy commented Oct 19, 2024

@systemcrash done

@systemcrash systemcrash merged commit ec585c2 into openwrt:master Oct 19, 2024
1 check passed
@systemcrash
Copy link
Contributor

Great, thanks @kumy !

@kumy kumy deleted the patch-1 branch October 19, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants