luci-app-nft-qos: Remove the redundant MAC address of the static IP speed limit #6477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Those are not "development versions" but stable releases. Your commit is missing the signed-off-by line. I am trying to understand the actual issue: Is this a correction to 1166050 by @lzto that removed the macaddr option from download (lines 135-138) but left it for upload (lines 170-172) ? |
|
Fix previous display Vs Display after repair |
|
I think that I will cherry-pick your fix to master although you closed the PR (due to extra commits?) (I am not using nft-qos myself, but the fix seems correct in light of 1166050 and your screenshots) |
hnyman
added a commit
to hnyman/luci
that referenced
this pull request
Jul 27, 2023
Remove the redundant upload rate MAC address field. Download was removed by 1166050 of PR openwrt#4351, but upload was overlooked. Reference to PR openwrt#6477. Signed-off-by: Hannu Nyman <[email protected]>
hnyman
added a commit
to hnyman/luci
that referenced
this pull request
Jul 27, 2023
Remove the redundant upload rate MAC address field. Download was removed by 1166050 of PR openwrt#4351, but upload was overlooked. Reference to PR openwrt#6477. Signed-off-by: Hannu Nyman <[email protected]> (cherry picked from commit 68a671d)
|
I accidentally synced the official openwrt source code! You can continue
to fix! I want to upgrade nft-qos to version 2.0, merged into one column:
host, upload rate, download rate, rate unit! I have tested three speed
limit schemes: single ip address, ip network segment, and mac address all
take effect! But the code changes a lot!
Hannu Nyman ***@***.***> 于 2023年7月27日周四 23:04写道：
… I think that I will cherry-pick your fix to master although you closed the
PR (due to extra commits?)
(I am not using nft-qos myself, but the fix seems correct in light of
1166050
<1166050>
and your screenshots)
—
Reply to this email directly, view it on GitHub
<#6477 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANUY23DLYJ4YPZYPCCABZ23XSJ7P7ANCNFSM6AAAAAA2VDWNJ4>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
I applied your original small fix to master and 23.05 |
|
thank you for your help! I will provide a new version later for everyone
to discuss! power outage at home
Hannu Nyman ***@***.***> 于 2023年7月28日周五 01:20写道：
… I applied your original small fix to master and 23.05
—
Reply to this email directly, view it on GitHub
<#6477 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANUY23EL3GJ6EQ6YNXJIYSLXSKPMBANCNFSM6AAAAAA2VDWNJ4>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following development versions of OpenWrt can remove the old IP address static redundant MAC form option:
OpenWrt 23.05
OpenWrt 22.03
OpenWrt 21.02