luci-app-tor: Manage tor-hs onion services

[stokito]

There was a PR #711 but it was focused on the Proxy configuration which is not fully yet supported by UCI.
The PR adds an ability to configure Tor Hidden Services as a good option to bypass NAT and have a stable access to a router.

Later once the main Tor package gains a support of a Proxy/Bridge configuration we can add this to the same luci app as a different view.

If you accept the PR please also check this small improvement openwrt/packages#21642

@ja-pa you created the tor-hs package so please check and leave your feedback

[stokito]

There is a Name fields that is later used by the tor-hs package when a keys folder created for a service. Ideally instead it should be a uci section name used.
Anyway we can't update existing configuration where sections doesn't have a name.
Still I think that the section name must be set clearly.
So the PR has named hidden-service sections and when adding a new the Name field will be populated with a name of section. Users are free to change it if they need.
Existing unnamed sections will be shown as cfg1234 but their Name field remain intact and even can be edited.
Luci doesn't provide an option to edit section names but that's not critical.

[stangri]

You may want to make things a little easier and more error-prone for localizers, by changing things like:

_('<a href="https://openwrt.org/docs/guide-user/services/tor/hs" target="_blank">Tor Onion (Hidden) Services</a> are proxy tunnels to your local website, SSH and other services')

to

_('%sTor Onion (Hidden) Services%s are proxy tunnels to your local website, SSH and other services').format('<a href="https://openwrt.org/docs/guide-user/services/tor/hs" target="_blank">', '</a>')

[stokito]

That's a good idea. Still I feel that it would be better to keep as is for two reasons: * We may have a translated Wiki page * This is more clear and less error-prone.

…

On Thu, Aug 3, 2023 at 12:57 PM Stan Grishin ***@***.***> wrote: You may want to make things a little easier and more error-prone for localizers, by changing things like: _('<a href="https://openwrt.org/docs/guide-user/services/tor/hs" target="_blank">Tor Onion (Hidden) Services</a> are proxy tunnels to your local website, SSH and other services') to _('%sTor Onion (Hidden) Services%s are proxy tunnels to your local website, SSH and other services').format('<a href="https://openwrt.org/docs/guide-user/services/tor/hs" target="_blank">', '</a>'); — Reply to this email directly, view it on GitHub <#6476 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADFODVIQ6XPOX7GOXOUK5DXTNY2HANCNFSM6AAAAAA2UEDYKQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Sergey Ponomarev <https://linkedin.com/in/stokito>, stokito.com

[stokito]

Damn, it's already exists a PR with the app for the tor-hs #4805
But it stalled. I'll check what left there and will merge with mine work.
I made a search by tor in issues but didn't checked existing PRs :(

[stokito]

Ok, I checked and looks like my PR would be better:

1. The Hidden service status tab is not needed. Instead in my version just a link with onion domain is shown. It anyway can show only those onion services that are managed by the tor-hs
2. Common settings tab is not needed. No one will ever change anything there. See tor-hs: use named sections packages#21642 (comment)
3. Hidden service configuration has inline form while in my version it's modal.

[systemcrash]

That's a good idea. Still I feel that it would be better to keep as is for two reasons: * We may have a translated Wiki page * This is more clear and less error-prone.

There is a reason that links should be formatted like this: safety/security is one of them. It also unburdens the language translators.

[stokito]

@stangri I changed the link to:

m = new form.Map('tor-hs', _('Tor Onion Services'),
	_(
		'Tor Onion (Hidden) Services are proxy tunnels to your local website, SSH and other services.<br/>' +
		'For further information <a href="%s" target="_blank" rel="noreferrer">check the documentation</a>'
	).format('https://openwrt.org/docs/guide-user/services/tor/hs')
);

[stangri]

@stangri I changed the link to:

m = new form.Map('tor-hs', _('Tor Onion Services'),
	_(
		'Tor Onion (Hidden) Services are proxy tunnels to your local website, SSH and other services.<br/>' +
		'For further information <a href="%s" target="_blank" rel="noreferrer">check the documentation</a>'
	).format('https://openwrt.org/docs/guide-user/services/tor/hs')
);

Great job! Maybe you'd also consider removing HTML tags from translatable resources too?

[stokito]

@stangri I made as you you suggested and spitted.

[stokito]

I simplified acl file and made an explicit page for hidden services because in future we will have other pages to configure Tor client options like excluded countries

[stokito]

@systemcrash I applied changes that you requested.
Also I slightly changed description "A single port", "A pair ".

[systemcrash]

OK, so is the tor-hs and tor service difference here important? Should the luci app be (re)named appropriately? Or can this also manage tor?

[stokito]

In future we can add a new tab for the Tor routing configuration: SOCKS port, exclude countries etc. Maybe even we can allow to configure the Tor as VPN.
That's all can be added later but for now the tor package UCI doesn't have that much options.

[systemcrash]

Then the problem we have now is LUCI_DEPENDS:=. Installing this GUI does not imply any tor service is necessary. So as a start, add the tor-hs.

See e.g. pbr Makefile:

PKG_LICENSE:=GPL-3.0-or-later
PKG_MAINTAINER:=Stan Grishin <[email protected]>
PKG_VERSION:=1.1.1-7

LUCI_TITLE:=Policy Based Routing Service Web UI
LUCI_DESCRIPTION:=Provides Web UI for Policy Based Routing Service.
LUCI_DEPENDS:=+luci-base +jsonfilter +pbr

PKG_PROVIDES:=luci-app-vpnbypass luci-app-vpn-policy-routing

[stokito]

ok, fixed in the 612738d

[systemcrash]

Great, would you like to add the other fields?
e.g.

PKG_LICENSE:=?
PKG_MAINTAINER:=Sergey Ponomarev <[email protected]>

LUCI_DESCRIPTION:=

PKG_PROVIDES:=

[stokito]

I added the package version, release and maintainer. Everything else like License will be inherited from Luci.

[systemcrash]

OK, and now for consistency: can you order those additions so they're like other Makefiles? e.g.

PKG_*

LUCI_*

[stokito]

As far I know that should be enough: it has own version and maintainer but everything else same as for the luci.
Here is for example transmission app that has only Title and Depends:
https://github.com/openwrt/luci/blob/master/applications/luci-app-transmission/Makefile

[stokito]

Thank you

[systemcrash]

Thanks for your patience 😄