Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-app-crowdsec-firewall-bouncer: new app #6216

Merged

Conversation

ne20002
Copy link
Contributor

@ne20002 ne20002 commented Jan 30, 2023

Signed-off-by: S. Brusch [email protected]

Maintainer: S. Brusch [email protected]
Compile tested: no compile, script
Run tested: ipq40xx/generic, Fritzbox 4040, Openwrt 22.03.3

Description: this is the luci app for crowdsec-firewall-bouncer package

@ne20002
Copy link
Contributor Author

ne20002 commented Jan 30, 2023

This is the luci app for the new version of the crowdsec-firewall-bouncer (see this pull request).

@ne20002
Copy link
Contributor Author

ne20002 commented Feb 7, 2023

Hi @jow-
I wonder if you can help with this PR. This is a new package with a LuCI app for the crowdsec-firewall-bouncer package. I don't know or found info on how to get a new package reviewed and merged. Is there any special user / group / email I need to contact?

@trippleflux
Copy link

trippleflux commented Feb 7, 2023

@ne20002

I think you need to add

# call BuildPackage - OpenWrt buildroot signature

At the end of Makefile , without it my OpenWrt build environment didn't picked up your package.

@ne20002 ne20002 force-pushed the luci-app-crowdsec-firewall-bouncer branch from 0547386 to 366ae76 Compare February 7, 2023 16:21
@ne20002
Copy link
Contributor Author

ne20002 commented Feb 7, 2023

I think you need to add

Added. How about now?

@trippleflux
Copy link

Picked it up by OpenWrt, thanks.

@stangri
Copy link
Member

stangri commented Feb 7, 2023

@ne20002
Copy link
Contributor Author

ne20002 commented Feb 8, 2023

JavaScript is required for new apps.

@stangri
PR is now updated (with JavaScript).

@ne20002 ne20002 force-pushed the luci-app-crowdsec-firewall-bouncer branch 4 times, most recently from c3f6b6c to cf254f9 Compare February 11, 2023 14:11
@ne20002
Copy link
Contributor Author

ne20002 commented Feb 11, 2023

Picked it up by OpenWrt, thanks.
Hi @trippleflux
Updated package with JavaScript

@ne20002 ne20002 force-pushed the luci-app-crowdsec-firewall-bouncer branch from cf254f9 to 0ed5174 Compare February 11, 2023 16:35
@ne20002
Copy link
Contributor Author

ne20002 commented Feb 14, 2023

Hi @feckert
May it be possible to get this reviewed as well? I followed coding on the findings of luci-app-bcp38. Thank you very much.

@trippleflux
Copy link

Picked it up by OpenWrt, thanks.
Hi @trippleflux
Updated package with JavaScript

Just got the chance to updating my OpenWrt build, haven't tested your package, will try today hopefully.

@trippleflux
Copy link

@ne20002

Where is the app located in luci?, I could not found it anywhere. Under "Services" nothing about crowdsec-firewall-bouncer.

@ne20002 ne20002 force-pushed the luci-app-crowdsec-firewall-bouncer branch from 0ed5174 to 4d6bb13 Compare February 14, 2023 14:05
@ne20002
Copy link
Contributor Author

ne20002 commented Feb 14, 2023

@ne20002

Where is the app located in luci?, I could not found it anywhere. Under "Services" nothing about crowdsec-firewall-bouncer.

It's similar to bcp38 so it's in Network/Firewall.

@ne20002 ne20002 requested a review from jow- February 16, 2023 15:46
@trippleflux
Copy link

@ne20002
I am sorry that I cannot getting crowdsec to work so cannot verified or testing the functionalities, but quick UI test seems working.

@ne20002
Copy link
Contributor Author

ne20002 commented Feb 21, 2023

I am sorry that I cannot getting crowdsec to work so cannot verified or testing the functionalities, but quick UI test seems working.

Actually, to get CrowdSec to work you need a local API instance, an CrowdSec account, at least an agent and a bouncer. The crowdsec-firewall-bouncer covers only a bouncer running on the OpenWrt router and this package is just a UI for the most common configuration settings for the crowdsec-firewall-bouncer.
Most OpenWrt devices do not have enough resources to host a CrowdSec local API but the bouncer only (which is just a filter for malicious ips collected by either local agents (on backend systems) or retrieved via CrowdSec central API from community blacklists).

@trippleflux
Copy link

@ne20002
Thank you for the explanation, yes I am on x86_64 router with quite beefy specs, was spent couple hours trying to get it work but no result for me, and I don't want to polluted your PR with crowdsec howtos. But judging from your OpenWrt posts, I am sure you have thinking it through well enough.

@ne20002
Copy link
Contributor Author

ne20002 commented Feb 21, 2023

@trippleflux

But judging from your OpenWrt posts, I am sure you have thinking it through well enough.

It's working quite well. ;)

When I get my PR merged (and hopefully both packages also merged into 22.03) I will see if I can update the Wiki as well. It is a bit outdated as it does not reflect the uci configuration of the new crowdsec-firewall-bouncer package and also that it is now based on nftables only.

@Hukuma1
Copy link

Hukuma1 commented Feb 21, 2023

Can't wait to try to run CS on (hopefully) 22.03. Thank you for these PRs!

I also run AdGuard Home on OpenWrt. Will CS work alongside it just fine or will some adjustments need to be made?

@ne20002
Copy link
Contributor Author

ne20002 commented Feb 21, 2023

Can't wait to try to run CS on (hopefully) 22.03. Thank you for these PRs!

We have a forum discussion for details and shouldn't bloat this PR comments with this kind of stuff.
I don't see why those two shouldn't work alongside without problems.

@ne20002
Copy link
Contributor Author

ne20002 commented Feb 24, 2023

Hi @stangri
May I ask how I can speed up merging my PR? We have a few users waiting for the package. Also, how is porting to 22.03 branch handled? Is there anything I can do?

@ne20002
Copy link
Contributor Author

ne20002 commented Mar 13, 2023

Hi @trippleflux
This PR is still open/pending. As the crowdsec-firewall-bouncer has been merged (to master and 23.03) this luci app would be appreciated by (at least) a few users.
Did I miss somethig doing?

@trippleflux
Copy link

@ne20002
I am not an OpenWrt developer/member, I still haven't test the functionalities wise, but I am trusting your judgement and qualities of work as you are already 'beta-test' it with others OpenWrt forums member. Only my personal judgement, I hope also this will gets merged soon.

@ne20002 ne20002 changed the title crowdsec-firewall-bouncer: add app new app: crowdsec-firewall-bouncer Mar 17, 2023
@ne20002
Copy link
Contributor Author

ne20002 commented May 6, 2023

Hi @stangri
My PR is stale. What can I do about it? Is anything missing?

@ne20002 ne20002 force-pushed the luci-app-crowdsec-firewall-bouncer branch from 4d6bb13 to 1a7b087 Compare May 17, 2023 09:38
Signed-off-by: S. Brusch <[email protected]>

Maintainer: S. Brusch <[email protected]>
Compile tested: no compile, script
Run tested: ipq40xx/generic, Fritzbox 4040, Openwrt 22.03.3

Description: this is the luci app for crowdsec-firewall-bouncer package
@ne20002 ne20002 force-pushed the luci-app-crowdsec-firewall-bouncer branch from 1a7b087 to 3a4843f Compare July 25, 2023 11:17
@ne20002 ne20002 force-pushed the luci-app-crowdsec-firewall-bouncer branch from 33c8a6a to 3a4843f Compare September 15, 2023 12:24
@ne20002 ne20002 changed the title new app: crowdsec-firewall-bouncer luci-app-crowdsec-firewall-bouncer: new app Oct 2, 2023
@ne20002 ne20002 marked this pull request as draft October 2, 2023 16:51
@ne20002 ne20002 marked this pull request as ready for review October 2, 2023 16:51
@systemcrash systemcrash merged commit dd3f5c6 into openwrt:master Dec 4, 2023
4 checks passed
@hnyman
Copy link
Contributor

hnyman commented Dec 4, 2023

@systemcrash
Please fix the garbage (missing "\n") causing weblate problem spam...

Parsing failed
[Hosted Weblate](https://hosted.weblate.org/) / [OpenWrt](https://hosted.weblate.org/projects/openwrt/) / [LuCI/applications/crowdsec-firewall-bouncer](https://hosted.weblate.org/projects/openwrt/luciapplicationscrowdsec-firewall-bouncer/) / [English](https://hosted.weblate.org/projects/openwrt/luciapplicationscrowdsec-firewall-bouncer/en/)
Error message

unknown encoding: UTF-8""Co

Failing file

applications/luci-app-crowdsec-firewall-bouncer/po/en/crowdsec-firewall-bouncer.po

@systemcrash
Copy link
Contributor

Thanks. Got it.

systemcrash added a commit that referenced this pull request Dec 4, 2023
luci-app-crowdsec-firewall-bouncer: new app
(cherry picked from commit dd3f5c6)

luci-app-crowdsec-firewall-bouncer: add newline correction

Signed-off-by: Paul Donald <[email protected]>
(cherry picked from commit e4dc88d)
systemcrash added a commit that referenced this pull request Dec 4, 2023
luci-app-crowdsec-firewall-bouncer: new app
(cherry picked from commit dd3f5c6)

luci-app-crowdsec-firewall-bouncer: add newline correction

Signed-off-by: Paul Donald <[email protected]>
(cherry picked from commit e4dc88d)
@ne20002 ne20002 deleted the luci-app-crowdsec-firewall-bouncer branch January 3, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants