Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scripts] Remove unnecessary logic from stop script #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brada4
Copy link

@brada4 brada4 commented Sep 2, 2024

Always remove table and service state to have consistent cleaned up system state on exit even if user intentionally dropped our table. Removes dependency on grep as a consequence.

Ref: https://wiki.nftables.org/wiki-nftables/index.php/Configuring_tables
Supersedes: #33

Signed-off-by: Andris PE [email protected]

Always remove table and service state to have consistent cleaned up
system state on exit even if user intentionally dropped our table.
Removes dependency on grep as a consequence.

Ref: https://wiki.nftables.org/wiki-nftables/index.php/Configuring_tables
Supersedes: openwrt#33
Signed-off-by: Andris PE <[email protected]>
@brada4
Copy link
Author

brada4 commented Sep 2, 2024

Hi @jow-
According to "upstream documentation" no need to perform any checks before deleting table since kernel 4.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant