builder: add more consistency and finer granularity to build status #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1037 +/- ##
==========================================
+ Coverage 80.75% 90.72% +9.96%
==========================================
Files 15 14 -1
Lines 977 1110 +133
==========================================
+ Hits 789 1007 +218
+ Misses 188 103 -85 ☔ View full report in Codecov by Sentry. |
efahl
force-pushed
the
status-consistency
branch
from
953d734
to
ab60d27
Compare
|
Overall super nice work! I'd be nice if you could split things into smaller commits in the future to make things easier to review and later on find errors |
aparcar
requested changes
Oct 16, 2024
efahl
force-pushed
the
status-consistency
branch
from
ab60d27
to
63e6135
Compare
aparcar
reviewed
Oct 17, 2024
Ensure that 'imagebuilder_status' is reported at all phases of build, and add a final "done" status. Ensure that all GET and HEAD requests to '/build' receive all x-headers regardless of build phase. After reading through all the FastAPI docs, it turns out you can put '@get' and '@Head' on the same function and it works just as you would expect. Reduces code size a bit. Extended the 'build_get' test to also include the HEAD request and confirm that sequential HEAD and GET requests receive the same data. Signed-off-by: Eric Fahlgren <[email protected]>
efahl
force-pushed
the
status-consistency
branch
from
63e6135
to
f40c8d1
Compare
aparcar
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that 'imagebuilder_status' is reported at all phases of build, and add a final "done" status.
Ensure that all GET and HEAD requests to '/build' receive all x-headers regardless of build phase.
After reading through all the FastAPI docs, it turns out you can put '@get' and '@Head' on the same function and it works just as you would expect. Reduces code size a bit.
Extended the 'build_get' test to also include the HEAD request and confirm that sequential HEAD and GET requests receive the same data.