chore: improve typing and annotations on BuildRequest #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add full annotations to all BuildRequest members, including the verbose descriptions from the pre-pydantic API. This produces much better documentation in the redoc and api docs. Also did a little semantic reordering, so the flow of the docs is a bit better. Signed-off-by: Eric Fahlgren <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1036 +/- ##
==========================================
+ Coverage 80.75% 90.55% +9.79%
==========================================
Files 15 14 -1
Lines 977 1080 +103
==========================================
+ Hits 789 978 +189
+ Misses 188 102 -86 ☔ View full report in Codecov by Sentry. |
|
Excellent thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add full annotations to all BuildRequest members, including the verbose descriptions from the pre-pydantic API. This produces much better documentation in the redoc and api docs. Also did a little semantic reordering, so the flow of the docs is a bit better.