Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add some typing #1023

Merged
merged 1 commit into from
Oct 6, 2024
Merged

chore: add some typing #1023

merged 1 commit into from
Oct 6, 2024

Conversation

aparcar
Copy link
Member

@aparcar aparcar commented Oct 6, 2024

No description provided.

Signed-off-by: Paul Spooren <[email protected]>
Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.56%. Comparing base (5e65dec) to head (1fd429b).
Report is 119 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1023      +/-   ##
==========================================
+ Coverage   80.75%   90.56%   +9.80%     
==========================================
  Files          15       14       -1     
  Lines         977     1081     +104     
==========================================
+ Hits          789      979     +190     
+ Misses        188      102      -86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aparcar
Copy link
Member Author

aparcar commented Oct 6, 2024

@efahl would you be so kind and help with this typing effort :)?

@aparcar aparcar merged commit b823611 into openwrt:main Oct 6, 2024
4 checks passed
@efahl
Copy link
Contributor

efahl commented Oct 6, 2024

No problem. I've got a bunch of typing/docstring-ish stuff in BuildRequest that I've been sitting on for months that I'll polish up and submit, and look at the rest of this, too.

@efahl
Copy link
Contributor

efahl commented Oct 7, 2024

@aparcar, do you have mypy or something added to your env to test the typing annotations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants