-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to bootstrap #441
Migrate to bootstrap #441
Conversation
I will setup a meeting to discuss any changes to be made |
d9a4007
to
43cdac6
Compare
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
43cdac6
to
576aa90
Compare
Just a couple tweaks I noticed above that are worth focusing on but in general looking good. I think there's some more grid changes and alignment tweaks for the "header-desc" info boxes we should do, however not worth looking at right now as they are working close enough as intended and we should go through a UX review to see if those will dramatically change anyways. So (after tweaks above) worth merging and deploying to dev (to check on other devices) and then having UX review with Kim before going too much further |
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Just pushed these changes. Thanks for the feedback and testing. Should be good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for this milestone.
This pr resolves #431
All that remains when it comes to CSS are classes or IDs accessed via javascript (should be resolved with #432) or custom overrides for bootstrap it's self.
Updated look for desktop:
Updated look for mobile: