Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to bootstrap #441

Merged
merged 5 commits into from
Mar 21, 2024
Merged

Migrate to bootstrap #441

merged 5 commits into from
Mar 21, 2024

Conversation

Gavinok
Copy link
Contributor

@Gavinok Gavinok commented Mar 19, 2024

This pr resolves #431

All that remains when it comes to CSS are classes or IDs accessed via javascript (should be resolved with #432) or custom overrides for bootstrap it's self.

Updated look for desktop:
2024-03-19_12-30-53

Updated look for mobile:
2024-03-19_12-28-50

@Gavinok Gavinok requested review from loneil and esune March 19, 2024 19:32
@Gavinok
Copy link
Contributor Author

Gavinok commented Mar 19, 2024

I will setup a meeting to discuss any changes to be made

@loneil
Copy link
Contributor

loneil commented Mar 20, 2024

One note from Kim, can we move the refresh icon to the left here
image

like it was originally
image
(but keeping the new opaqueness, that's a good improvement for readability)

"To the left please. That makes it seem more like a button and less like a status"

Also when I hover it, it whites out the text, should adjust that to stay readable (this was chrome desktop)
image

@loneil loneil force-pushed the migrate-to-bootstrap branch from d9a4007 to 43cdac6 Compare March 20, 2024 22:26
@loneil loneil force-pushed the migrate-to-bootstrap branch from 43cdac6 to 576aa90 Compare March 20, 2024 22:28
@loneil
Copy link
Contributor

loneil commented Mar 20, 2024

Also get a big blue outline in the pending state

image

@loneil
Copy link
Contributor

loneil commented Mar 20, 2024

Just a couple tweaks I noticed above that are worth focusing on but in general looking good.

I think there's some more grid changes and alignment tweaks for the "header-desc" info boxes we should do, however not worth looking at right now as they are working close enough as intended and we should go through a UX review to see if those will dramatically change anyways.

So (after tweaks above) worth merging and deploying to dev (to check on other devices) and then having UX review with Kim before going too much further

@Gavinok
Copy link
Contributor Author

Gavinok commented Mar 20, 2024

Just a couple tweaks I noticed above that are worth focusing on but in general looking good.

I think there's some more grid changes and alignment tweaks for the "header-desc" info boxes we should do, however not worth looking at right now as they are working close enough as intended and we should go through a UX review to see if those will dramatically change anyways.

So (after tweaks above) worth merging and deploying to dev (to check on other devices) and then having UX review with Kim before going too much further

Just pushed these changes. Thanks for the feedback and testing. Should be good to go now.

Copy link
Contributor

@loneil loneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for this milestone.

@Gavinok Gavinok merged commit 27d0a3c into main Mar 21, 2024
5 checks passed
@loneil loneil deleted the migrate-to-bootstrap branch May 3, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transition to Bootstrap for UI positioning
2 participants