-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add responsive sizing of VCAuthn login page for mobile devices #430
Conversation
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
c589f8f
to
edcf0f1
Compare
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
@Gavinok can you resolve the conflicts - likely with code from the last merged PR? |
@esune working on this now |
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
@esune resolved the conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM based on screenshots and what demonstrated during live review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holding this as deep link is no longer delivering request message (working on main fine)
@Gavinok see comment above, not working with form action, needs to be an href link I believe. Probably: https://stackoverflow.com/questions/45542773/how-to-style-an-anchor-as-a-button-in-bootstrap-4 |
Dang that was what made is able to remove all that custom button CSS :( |
I'm wondering if we should tackle the UI redesign/tweaks as part of the full move to Bootstrap, rather than potentially do the work twice? #431 |
No should just need to change |
It was more to do with the css not indicating the button was disabled but I was able to work around this anyways |
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
e0fdc1e
to
6bf78a4
Compare
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
@loneil is it just me or does the qr code expire extremely fast now? Did I make a change that could effect that? |
Signed-off-by: Gavin Jaeger-Freeborn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, should be good to deploy for more device testing in dev. Can refine further with bootstrap framework.
This PR resolves #420 using media queries as well as bootstrap.
Here is the new desktop view
To ensure uniform rendering of the boarder it no longer uses a dedicated svg and instead uses CSS boarders
On mobile devices the card style is removed and instead the entire screen is used to make the most of the smaller displays.