Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename packages into @sd-jwt #77

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

lukasjhan
Copy link
Member

Changes

  • change name of packages
  • remove changelog.md
  • fix package.json workspace(?)

},
"dependencies": {
"@hopae/sd-jwt-type": "2.0.3",
"@hopae/sd-jwt-util": "2.0.3"
"@sd-jwt/types": "workspace:*",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cre8 This part has actual version. So I changed it to workspace:* again.
I think lerna publish set the version here. Was this intentional?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah workspace:* should be swapped by lerna for the release. You can check the setup at https://github.com/berendsliedrecht/sd-jwt-ts as we used the exact same setup there.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think when you run lerna version it will set it. Using * seems better for me.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (9025c49) 65.70% compared to head (5f45586) 65.50%.

Files Patch % Lines
examples/present-example/present.ts 0.00% 2 Missing and 1 partial ⚠️
examples/core-example/all.ts 0.00% 1 Missing and 1 partial ⚠️
examples/core-example/basic.ts 0.00% 1 Missing and 1 partial ⚠️
examples/core-example/custom.ts 0.00% 1 Missing and 1 partial ⚠️
examples/core-example/custom_header.ts 0.00% 1 Missing and 1 partial ⚠️
examples/core-example/decoy.ts 0.00% 1 Missing and 1 partial ⚠️
examples/core-example/kb.ts 0.00% 1 Missing and 1 partial ⚠️
examples/core-example/sdjwtobject.ts 0.00% 1 Missing and 1 partial ⚠️
examples/decode-example/decode.ts 0.00% 1 Missing and 1 partial ⚠️
examples/core-example/decode.ts 0.00% 0 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   65.70%   65.50%   -0.20%     
==========================================
  Files          33       33              
  Lines        2114     2102      -12     
  Branches      233      233              
==========================================
- Hits         1389     1377      -12     
  Misses        706      706              
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukasjhan lukasjhan mentioned this pull request Feb 22, 2024
@lukasjhan lukasjhan merged commit 913b446 into openwallet-foundation-labs:main Feb 22, 2024
6 of 8 checks passed
cre8 pushed a commit to cre8/sd-jwt-js that referenced this pull request Mar 8, 2024
cre8 pushed a commit that referenced this pull request Mar 8, 2024
Signed-off-by: Lukas <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants