-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace eslint with biome #74
Conversation
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
@lukasjhan @berendsliedrecht I have added the biome config, but haven't applied any format changes so we can check if we are fine with the rules. |
Some of code line failed with the current rules. Do you want to fix that later? |
linter works well, 30+ founds :D |
@lukasjhan the intention of my first commits was to get feedback for the defined rules ;) |
exclude coverage folder Co-authored-by: Lukas.J.Han <[email protected]> Signed-off-by: Mirko Mollik <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
=======================================
Coverage ? 65.70%
=======================================
Files ? 33
Lines ? 2114
Branches ? 233
=======================================
Hits ? 1389
Misses ? 706
Partials ? 19 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mirko Mollik <[email protected]>
! and any. hmm... In my opinion, the rules in this PR is okay. Kinds of reasonable rules. |
"rules": { | ||
"recommended": true, | ||
"suspicious": { | ||
"noExplicitAny": "off" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to get rid of all the any
uses. I can get rid of this later, so we can just leave it like this for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@berendsliedrecht I opened an issue for this #79 , feel free to work on this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the really quick pick up! Really liking the look of the setup and how easy it seems :).
Signed-off-by: Mirko Mollik <[email protected]> Signed-off-by: Mirko Mollik <[email protected]> Co-authored-by: Mirko Mollik <[email protected]> Co-authored-by: Lukas.J.Han <[email protected]> Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]> Signed-off-by: Mirko Mollik <[email protected]> Co-authored-by: Mirko Mollik <[email protected]> Co-authored-by: Lukas.J.Han <[email protected]> Signed-off-by: Mirko Mollik <[email protected]>
eslint is not designed to support monorepos, biome seems to work pretty well for this.
The job is not run via lerna but by bionme on the root level. This allows to follow the links printent in the console. It okay to lint every project independent if it has updated files since all projects should be compliant to linting rules.