Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Feat/versioning #71

Merged
merged 17 commits into from
Feb 21, 2024
Merged

Conversation

cre8
Copy link
Contributor

@cre8 cre8 commented Feb 20, 2024

Update of this PR:

vitest usage: vitest was configured for workspace usage. This will generate a coverage report for all files (open todos: publish result file to codecoverage for better inspection. We need to set a token as a secret).

adding lint: to improve code quality lint was added. But for not it is outcomment during the ci since it would not pass ;)

optimized ci: I used veramos one as a reference. It will build and test the code. It will also publish the code to NPM when it is on one of the specific branches

  • if its on main, it will publish the latest version and also with a new version number based on the tags. It will also generate a release
  • if its on next, it will publish the latest version under the next tag, but will not give it a new version number
  • similar to next, but it will publish it with the unstable tag.

Signed-off-by: Mirko Mollik [email protected]

lukasjhan
lukasjhan previously approved these changes Feb 20, 2024
Copy link
Member

@lukasjhan lukasjhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)
Is it ready to merge?

@cre8
Copy link
Contributor Author

cre8 commented Feb 20, 2024

@lukasjhan not yet

@cre8 cre8 changed the title Feat/versioning WIP: Feat/versioning Feb 20, 2024
@cre8
Copy link
Contributor Author

cre8 commented Feb 20, 2024

@lukasjhan since I am not getting the results I want with lerna, I will try to migrate to NX which seems to be more up to date how to handle monorepos.

@lukasjhan
Copy link
Member

@cre8 The direction of change seems to be good, but what part is not working well?

@cre8
Copy link
Contributor Author

cre8 commented Feb 21, 2024

@cre8 The direction of change seems to be good, but what part is not working well?

The continuous deployment is not working. Lerna has the call to generate the changelog and the updated version in the package jsons. But I found no good way to push these changes to the GitHub branch inside the GitHub action. I also found no documentation on the Lerna website.

Three options:

  • we are doing the release manually in the short run
  • we are checking how other projects using Lerna in their cicd have solved it
  • we switch to other tools like nx where are plugins to publish

I already tested the switch to nx and it was done in 10 minutes.

I will evaluate all three options today so we merge this PR successful

@lukasjhan
Copy link
Member

I'll put sd-jwt-vc PR after this :)

@cre8
Copy link
Contributor Author

cre8 commented Feb 21, 2024

@lukasjhan I updated this entry so it can be reviewed again by you :)

@cre8
Copy link
Contributor Author

cre8 commented Feb 21, 2024

I am not sure if the publish step will work at this point because I cannot check if we have all the required variables and secrets set

@lukasjhan
Copy link
Member

Okay :) I'm reviewing right now.
The DCO check is failed. Do you want to bypass it?

@cre8
Copy link
Contributor Author

cre8 commented Feb 21, 2024

I will fix the the DCO check by resigning in an hour.

cre8 and others added 15 commits February 21, 2024 10:39
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
@cre8
Copy link
Contributor Author

cre8 commented Feb 21, 2024

@lukasjhan done, an hour is relative :D

All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [2.0.3](https://github.com/openwallet-foundation-labs/sd-jwt-js/compare/v2.0.2...v2.0.3) (2024-02-20)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that this changelog generated automatically, is it right?
It might be needed to fix manually as we discuss in #44. To 0.x

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove the generated one from this PR. As mentioned above, I don't know what's the best way to generate the changelog that should be part of the github repo. It should be relatively easy to use the release mechanism of github

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cre8 I think we might need to reset all the tags in this repo when we deploy to @sd-jwt/*

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess release mechanism of github is easiest way :D.

@lukasjhan lukasjhan merged commit b259b86 into openwallet-foundation-labs:main Feb 21, 2024
5 checks passed
@cre8 cre8 deleted the feat/versioning branch February 21, 2024 10:30
cre8 added a commit to cre8/sd-jwt-js that referenced this pull request Mar 8, 2024
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Lukas.J.Han <[email protected]>
Signed-off-by: Lukas <[email protected]>
Co-authored-by: Mirko Mollik <[email protected]>
Co-authored-by: Lukas.J.Han <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
cre8 added a commit that referenced this pull request Mar 8, 2024
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Lukas.J.Han <[email protected]>
Signed-off-by: Lukas <[email protected]>
Co-authored-by: Mirko Mollik <[email protected]>
Co-authored-by: Lukas.J.Han <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants