Feat/type metadata #247
Merged
Feat/type metadata #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
cre8
requested review from
lukasjhan,
zustkeeper and
berendsliedrecht
as code owners
Signed-off-by: Mirko Mollik <[email protected]>
lukasjhan
reviewed
Aug 18, 2024
lukasjhan
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the schema validation based on the typed metadata.
This feature has to be activated with a parameter when the instance is created without breaking existing applications. The function to fetch the typed metadata can be overridden, the default one with fetch it from the url.
At this point it is only used for validation, after this MR got merged, the metadata should be fetched via a function (either be returned after the validation and/or it's able to fetch them via a dedicated call to skip the validation of the credential) to receive the display information.