Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check if the header includes the string #244

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix: check if the header includes the string #244

merged 1 commit into from
Jul 30, 2024

Conversation

cre8
Copy link
Contributor

@cre8 cre8 commented Jul 30, 2024 •
edited
Loading

Before we checked for equal, ignoring that the charset will be added. Using include solves this problem

Signed-off-by: Mirko Mollik [email protected]

lukasjhan
lukasjhan approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@lukasjhan lukasjhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@cre8 cre8 merged commit 8a48bb5 into openwallet-foundation-labs:main Jul 30, 2024
7 checks passed
@cre8 cre8 deleted the fix/revocation branch August 15, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasjhan lukasjhan lukasjhan approved these changes

@zustkeeper zustkeeper Awaiting requested review from zustkeeper zustkeeper is a code owner

@berendsliedrecht berendsliedrecht Awaiting requested review from berendsliedrecht berendsliedrecht is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cre8 @lukasjhan