-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/husky #185
Feat/husky #185
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 23 23
Lines 2074 2074
Branches 307 307
=======================================
Hits 2033 2033
Misses 41 41 ☔ View full report in Codecov by Sentry. |
@lukasjhan When I am using the commit via the command line like I used husky because it had the biggest community |
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Not the biggest fan of husky as the CI validates everything and husky just slows me down :'). No real issue, just find it a bit annoying and thats mainly why we disabled it within Credo. |
I've never used it before but, um.. Is it because husky check the codes every time I commit? |
Signed-off-by: Mirko Mollik <[email protected]>
@berendsliedrecht the problem with lerna publish is that it will update the package.json files to add the new version number, commit and push it. We can not stop in the middle to run the format command so it get's aligned with biome. Or we go the other way around and change the biome rules so they fit with the changes lerna is performing. |
I think it will be okay since the code base is not large like credo. |
Yeah the size and biome performance should help a lot. As long as we don't have to wait for 50s+ for a commit it's all good :). |
Adding husky to work to format the files before commiting them.
Signed-off-by: Mirko Mollik [email protected]