-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add README.md for each packages #102
Add README.md for each packages #102
Conversation
Signed-off-by: Lukas <[email protected]>
Signed-off-by: Lukas <[email protected]>
Signed-off-by: Lukas.J.Han <[email protected]>
Signed-off-by: Lukas.J.Han <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #102 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 21 21
Lines 1514 1514
Branches 229 229
=======================================
Hits 1394 1394
Misses 113 113
Partials 7 7 ☔ View full report in Codecov by Sentry. |
@@ -1,6 +1,6 @@ | |||
![Coverage](https://img.shields.io/badge/coverage-93%25-green) | |||
![Coverage](https://img.shields.io/codecov/c/github/openwallet-foundation-labs/sd-jwt-js) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added codecov project :)
<meta name="description" content="SD JWT is a TypeScript library implementing the IETF SD-JWT specification for selective disclosure of JWT claims, enhancing privacy and security in digital communications." /> | ||
<meta name="keywords" content="SD JWT, TypeScript, JWT, JSON Web Token, selective disclosure, IETF, authentication, Node.js, React Native, security, privacy, data transmission" /> | ||
<meta name="author" content="OpenWallet Foundation" /> | ||
<meta property="og:title" content="SD JWT - TypeScript JWT Library" /> | ||
<meta property="og:type" content="website" /> | ||
<meta property="og:url" content="https://sdjwt.js.org" /> | ||
<meta property="og:image" content="https://avatars.githubusercontent.com/u/114502864?s=200&v=4" /> | ||
<meta property="og:description" content="SD JWT is a TypeScript library implementing the IETF SD-JWT specification for selective disclosure of JWT claims, enhancing privacy and security in digital communications." /> | ||
<meta property="og:site_name" content="SD JWT - TypeScript JWT Library" /> | ||
<meta property="og:locale" content="en_US" /> | ||
<link rel="canonical" href="https://sdjwt.js.org" /> | ||
<title>SD JWT - TypeScript SD JWT Library</title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added meta tags for SEO. Hopefully it gets better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just small notes, but all in all it looks good.
packages/utils/README.md
Outdated
@@ -0,0 +1,35 @@ | |||
![Coverage](https://img.shields.io/codecov/c/github/openwallet-foundation-labs/sd-jwt-js) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should keep in mind that our coverage rate is calculated for the whole project, not for every library by itself.
I don't see the need to present it for each individual, just to mention it ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good point. Maybe we should put the codecov link of our project. To see the details
What do you think about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove anything from the packages readme that does not belong there, e.g. the code coverage of the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay :) done in 900158b
Signed-off-by: Lukas.J.Han <[email protected]>
Signed-off-by: Lukas.J.Han <[email protected]>
Signed-off-by: Lukas.J.Han <[email protected]>
Signed-off-by: Lukas.J.Han <[email protected]>
@cre8 I updated some changes. :) |
Signed-off-by: Lukas.J.Han <[email protected]>
Signed-off-by: Lukas.J.Han <[email protected]>
Signed-off-by: Lukas <[email protected]> Signed-off-by: Lukas.J.Han <[email protected]> Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Lukas <[email protected]> Signed-off-by: Lukas.J.Han <[email protected]> Signed-off-by: Mirko Mollik <[email protected]>
It closes #87
This PR contains