Add README.md for each packages #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas <[email protected]>
Signed-off-by: Lukas <[email protected]>
Signed-off-by: Lukas.J.Han <[email protected]>
Signed-off-by: Lukas.J.Han <[email protected]>
lukasjhan
requested review from
zustkeeper,
berendsliedrecht and
cre8
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #102 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 21 21
Lines 1514 1514
Branches 229 229
=======================================
Hits 1394 1394
Misses 113 113
Partials 7 7 ☔ View full report in Codecov by Sentry. |
lukasjhan
commented
Feb 24, 2024
| @@ -1,6 +1,6 @@ | |||
|  | |||
|  | |||
There was a problem hiding this comment.
I added codecov project :)
lukasjhan
commented
Feb 24, 2024
Comment on lines
+6
to
+17
| <meta name="description" content="SD JWT is a TypeScript library implementing the IETF SD-JWT specification for selective disclosure of JWT claims, enhancing privacy and security in digital communications." /> | ||
| <meta name="keywords" content="SD JWT, TypeScript, JWT, JSON Web Token, selective disclosure, IETF, authentication, Node.js, React Native, security, privacy, data transmission" /> | ||
| <meta name="author" content="OpenWallet Foundation" /> | ||
| <meta property="og:title" content="SD JWT - TypeScript JWT Library" /> | ||
| <meta property="og:type" content="website" /> | ||
| <meta property="og:url" content="https://sdjwt.js.org" /> | ||
| <meta property="og:image" content="https://avatars.githubusercontent.com/u/114502864?s=200&v=4" /> | ||
| <meta property="og:description" content="SD JWT is a TypeScript library implementing the IETF SD-JWT specification for selective disclosure of JWT claims, enhancing privacy and security in digital communications." /> | ||
| <meta property="og:site_name" content="SD JWT - TypeScript JWT Library" /> | ||
| <meta property="og:locale" content="en_US" /> | ||
| <link rel="canonical" href="https://sdjwt.js.org" /> | ||
| <title>SD JWT - TypeScript SD JWT Library</title> |
There was a problem hiding this comment.
I added meta tags for SEO. Hopefully it gets better
cre8
approved these changes
Feb 24, 2024
packages/utils/README.md
Outdated
| @@ -0,0 +1,35 @@ | |||
|  | |||
There was a problem hiding this comment.
we should keep in mind that our coverage rate is calculated for the whole project, not for every library by itself.
I don't see the need to present it for each individual, just to mention it ;)
There was a problem hiding this comment.
Yeah, good point. Maybe we should put the codecov link of our project. To see the details
What do you think about it?
There was a problem hiding this comment.
I would remove anything from the packages readme that does not belong there, e.g. the code coverage of the project.
There was a problem hiding this comment.
Okay :) done in 900158b
Signed-off-by: Lukas.J.Han <[email protected]>
Signed-off-by: Lukas.J.Han <[email protected]>
Signed-off-by: Lukas.J.Han <[email protected]>
Signed-off-by: Lukas.J.Han <[email protected]>
|
@cre8 I updated some changes. :) |
Signed-off-by: Lukas.J.Han <[email protected]>
lukasjhan
commented
Feb 24, 2024
Signed-off-by: Lukas.J.Han <[email protected]>
cre8
pushed a commit
to cre8/sd-jwt-js
that referenced
this pull request
Mar 8, 2024
Signed-off-by: Lukas <[email protected]> Signed-off-by: Lukas.J.Han <[email protected]> Signed-off-by: Mirko Mollik <[email protected]>
cre8
pushed a commit
that referenced
this pull request
Mar 8, 2024
Signed-off-by: Lukas <[email protected]> Signed-off-by: Lukas.J.Han <[email protected]> Signed-off-by: Mirko Mollik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It closes #87
This PR contains