Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Mirko to the CODEOWNER #101

Merged

Conversation

lukasjhan
Copy link
Member

@cre8 I added you as CODEOWNER. It makes you a reviewer of PRs

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.07%. Comparing base (5143e7b) to head (36b985c).

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #101   +/-   ##
=======================================
  Coverage   92.07%   92.07%           
=======================================
  Files          21       21           
  Lines        1514     1514           
  Branches      229      229           
=======================================
  Hits         1394     1394           
  Misses        113      113           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukasjhan
Copy link
Member Author

All stages are passed. I don't know why coverage reporting stage failed from dependabot.

@lukasjhan lukasjhan self-assigned this Feb 24, 2024
@lukasjhan lukasjhan merged commit fb2e533 into openwallet-foundation-labs:next Feb 24, 2024
8 checks passed
@cre8
Copy link
Contributor

cre8 commented Feb 24, 2024

Looking at the file via github I see this error:

Unknown owner on line 5: make sure @pensivej exists and has write access to the repository
* @lukasjhan @pensivej @zustkeeper @berendsliedrecht @cre8

Was it a typo?

@lukasjhan
Copy link
Member Author

I think pensivej change his name. 404 https://github.com/pensivej.
I'll tell him to fix it.

cre8 pushed a commit to cre8/sd-jwt-js that referenced this pull request Mar 8, 2024
cre8 pushed a commit that referenced this pull request Mar 8, 2024
Signed-off-by: Lukas.J.Han <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants