Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Geti integration #4188

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

negvet
Copy link
Collaborator

@negvet negvet commented Jan 27, 2025

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2025 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added the TEST Any changes in tests label Jan 27, 2025
dst_dir=ov_export_dir,
)
xml_path = ov_export_dir / "exported_model.xml"
mapi_model = self.mapi_model_class.create_model(xml_path)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to specify a particular class: Model.create(...) should work


def test_export_and_infer_openvino(self):
"""Test exporting the model to OpenVINO."""
for precision in [OTXPrecisionType.FP16, OTXPrecisionType.FP32]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be done via pytest parametrization for verbosity

export_format=OTXExportFormatType.OPENVINO,
export_precision=OTXPrecisionType.FP32,
explain=True,
export_demo_package=True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there something special about exporting models as a demo package? Normal export is enough to run in the scenario declared here

if self.mapi_model_class is not None:
ov_optimized_dir = self.tmp_path / "ov_optimize"
ov_optimized_dir.mkdir(parents=True, exist_ok=True)
unzip_exportable_code(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't optimized_path already point to the compressed model?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants