Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hyperparameters #74

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

negvet
Copy link
Collaborator

@negvet negvet commented Sep 23, 2024

No description provided.

@negvet negvet marked this pull request as ready for review September 24, 2024 08:09
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.88%. Comparing base (60b82d3) to head (8179505).
Report is 2 commits behind head on releases/1.1.0.

Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/1.1.0      #74      +/-   ##
==================================================
- Coverage           93.91%   93.88%   -0.04%     
==================================================
  Files                  28       28              
  Lines                1890     1896       +6     
==================================================
+ Hits                 1775     1780       +5     
- Misses                115      116       +1     
Flag Coverage Δ
dev-py310 93.88% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look OK to me, but not sure of the purpose of them.
Could you briefly describe what this PR is for?

@negvet
Copy link
Collaborator Author

negvet commented Sep 24, 2024

Changes look OK to me, but not sure of the purpose of them. Could you briefly describe what this PR is for?

Main objective of this PR is to text hyperparameters of the methods.

In addition, I aligned the following: method state will store those hyperparameters, this might be helpful - after every explainer call you can access utilized hyperparameters.

@negvet negvet merged commit cb99489 into openvinotoolkit:releases/1.1.0 Sep 24, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants