Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accuracy tests #73

Conversation

GalyaZalesskaya
Copy link
Contributor

@GalyaZalesskaya GalyaZalesskaya commented Sep 20, 2024

pytest tests/perf/test_accuracy.py --dataset-data-root ... --dataset-ann-path ... - Run on passed dataset (COCO, VOC, ILSVRC)
pytest tests/perf/test_accuracy.py - Run on internal toy dataset (cheetah_voc)

  • Updated accuracy tests to handle datasets, test models and explain methods and save accuracy and time results to file
  • Added COCO, VOC, ILSVRC dataset support
  • Added passing dataset path for tests through CLI
  • Moved common functions convert_timm_to_ir from perf/test_performance.py to perf/perf_tests_utils.py to use in accuracy tests as well
  • Supported accuracy metric calculation for the Activation map

TODO:

  • Documentation update

@GalyaZalesskaya GalyaZalesskaya changed the title Add performance tests Add accuracy tests Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.94%. Comparing base (2bbf89d) to head (46aaf6c).

Additional details and impacted files
@@               Coverage Diff               @@
##           releases/1.1.0      #73   +/-   ##
===============================================
  Coverage           93.93%   93.94%           
===============================================
  Files                  28       28           
  Lines                1897     1898    +1     
===============================================
+ Hits                 1782     1783    +1     
  Misses                115      115           
Flag Coverage Δ
dev-py310 93.94% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GalyaZalesskaya GalyaZalesskaya marked this pull request as ready for review September 24, 2024 08:02
@goodsong81 goodsong81 added this to the 1.1.0 milestone Sep 24, 2024
tests/perf/test_accuracy.py Outdated Show resolved Hide resolved
tests/perf/test_accuracy.py Outdated Show resolved Hide resolved
tests/perf/test_accuracy.py Outdated Show resolved Hide resolved
tests/perf/test_accuracy.py Outdated Show resolved Hide resolved
goodsong81
goodsong81 previously approved these changes Sep 27, 2024
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good enough to me for current status.
I think we don't need to be too strict for the tests :)

openvino_xai/metrics/adcc.py Outdated Show resolved Hide resolved
tests/perf/conftest.py Outdated Show resolved Hide resolved
@GalyaZalesskaya GalyaZalesskaya enabled auto-merge (squash) September 30, 2024 07:10
@GalyaZalesskaya GalyaZalesskaya merged commit 5cf3879 into openvinotoolkit:releases/1.1.0 Sep 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants